search

magicmatatjahu / milv

Markdown internal & external links validation library and CLI
MIT License
11 stars 5 forks source link

The false positive error during link validation with anchor #9

Open mszostok opened 5 years ago

mszostok commented 5 years ago

Confirm these statements before you submit the issue:

Description Validator produces the false positive error during link validation with anchor. The link points to the existing localization but error The specified anchor doesn't exist is raised.

Logs:

+ docker run --rm --dns=8.8.8.8 --dns=8.8.4.4 -v /home/jenkins/workspace/community/governance:/community:ro magicmatatjahu/milv:0.0.6 --base-path=/community --ignore-internal ./community/sig-and-wg/sig-core/proposals/common-libraries.md
#################################################
#                     SUMMARY                   #
#################################################

+---------------------------------------------------------------+----------------------------------------------------------------------------------------------------------------------------------------+--------------------------------+
|                             FILE                              |                                                                  LINK                                                                  |          DESCRIPTION           |
+---------------------------------------------------------------+----------------------------------------------------------------------------------------------------------------------------------------+--------------------------------+
| ./community/sig-and-wg/sig-core/proposals/common-libraries.md | https://github.com/kyma-project/kyma/blob/09b945ec0a897822b40666e518f2f258ae66e7e8/tests/acceptance/servicecatalog/wait/wait.go#L8-L24 | The specified anchor doesn't   |
|                                                               |                                                                                                                                        | exist                          |
+                                                               +                                                                                                                                        +                                +
|                                                               |                                                                                                                                        |                                |
|                                                               |                                                                                                                                        |                                |
+---------------------------------------------------------------+----------------------------------------------------------------------------------------------------------------------------------------+--------------------------------+
magicmatatjahu commented 5 years ago

Hi @mszostok Firstly, sorry for that late response from me. At the moment milv support only ids for github markdowns files and some stack-overflow headings. I work on generic solution to identify id and headers from custom resources, but probably it will be in 0.1.0 version. Thanks also for using milv! :)