search

magico13 / KCT

Kerbal Construction Time - An addon for Kerbal Space Program
29 stars 40 forks source link

Clicking on VAB after warping to complete does not work #116

Closed weidtn closed 7 years ago

weidtn commented 8 years ago

1 2 I build a rocket, then I build it, but I cant roll it out. When I click on VAB i just get this strange window in the Screenshot.

magico13 commented 8 years ago

I'll need the log file to have any hope of figuring this out. Are you running RP-0? The screenshots make it look like you're running some sort of system resize and several others have mentioned issues with the RP-0 Preset (which I haven't been able to reproduce in my testing).

weidtn commented 8 years ago

RSS with Realism Overhaul and RP-0. What Logfile do you exactly need?

magico13 commented 8 years ago

About halfway down this post (also mentioned in the "reporting bugs" section of the KCT forum thread).

I've got a feeling it's the issue two others were seeing. If it is then the log will mention an error in KCT_MathParsing when trying to parse the Reconditioning Formula.

If you don't mind, could you also upload the save file? Upload the save and the log to dropbox/google drive/any other file storage site. You can .zip them if you want to as it makes the file much smaller.

weidtn commented 8 years ago

https://www.dropbox.com/s/7kjsvejlxjlw3go/Log%26Save.rar?dl=0

You were right with KCT_MathParsing, something seems to get negative...

magico13 commented 8 years ago

Alright, thank you for that. I won't be able to attempt any fixes until I get home from work, but I'll hopefully have a fix for this by tomorrow. I'm not sure what it is that's causing this, but it seems to be related only to RP-0 and only for certain setups (when I tested with RP-0 I wasn't having this happen). I'll let you know when I've got something for you to try. Thanks again.

magico13 commented 8 years ago

Somehow KCT is determining the vessel's mass to be negative, which then causes a negative in a square root, which ends up as NaN and then breaks further calculations. I've made it return a minimum of zero so that should take care of that issue. Test out this .dll and let me know if it works for you.

E: By the way, thank you immensely for including the save file. I couldn't reproduce it on my end until I loaded up the save. I hadn't even considered a negative mass as the issue until I opened the save in a text editor and looked at the ships directly.

weidtn commented 8 years ago

One strange thing was that I could just load the vessel in SPH to launch it. But now with this .dll it seems to work. Thank you!

tscharlii commented 8 years ago

Thank you! I was experiencing the same issue and the replacement dll fixed it for me as well. Not including a save game here, but I started a fresh RP-0 Game and built "My first rocket" from https://github.com/KSP-RO/RP-0/wiki/Tutorial:-Getting-Started

magico13 commented 7 years ago

Since the dev builds appear to fix this, I'm going to close this (I'm doing some cleanup). If it comes up again, please let me know.