search

magiconair / properties

Java properties scanner for Go
BSD 2-Clause "Simplified" License
323 stars 77 forks source link

have symbol equal in the value property #13

Closed wsf1991 closed 8 years ago

wsf1991 commented 8 years ago

Hi I ran into this issue from eBay fabio, i want to set property 'registry.consul.register.tags'. i.e. "key1=val1" as one of the tag, but it has this kind of error: [FATAL] 1.1.5. circular reference

is that a way to escape equal symbol. thanks

magiconair commented 8 years ago

The backslash should do the trick. Let me know if it doesn't then I'll have a look in one of the next days.

magiconair commented 8 years ago

Hmm, tested this with both fabio 1.1.5 and 1.1.6 and cannot reproduce this. However, I do noticed that the current 1.2 branch has a bug in that it does not register the tags at all.

# cat fabio.properties
...
registry.consul.register.tags = key1=val1
# ./fabio -cfg fabio.properties
...
2016/07/13 13:37:28 [INFO] consul: Registered fabio with tags "key1=val1"
...
magiconair commented 8 years ago

@wsf1991 : 1.2 does not have a bug. I just started it wrong. Can you provide a more detailed example, please? Otherwise, I'm going to close this.

wsf1991 commented 8 years ago

Hi Frank,

I pull Fabio master branch and set tags of Fabio registered in consul as key1=${env_var}, ...

Let me attach the error info later today. Thanks.

Regards, Shifei Wu

在 2016年7月13日，上午5:14，Frank Schröder notifications@github.com 写道：

@wsf1991 : 1.2 does not have a bug. I just started it wrong. Can you provide a more detailed example, please? Otherwise, I'm going to close this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

magiconair commented 8 years ago

ok, good since I can't reproduce that behavior either.

magiconair commented 8 years ago

I'll close this one for now. Please re-open if you have more information.