added ToMap and ToMap with filters so that users may be able to trans…

magiconair / properties

Java properties scanner for Go

BSD 2-Clause "Simplified" License

323 stars 77 forks source link

added ToMap and ToMap with filters so that users may be able to trans… #19

Closed AnirudhVyas closed 7 years ago

AnirudhVyas commented 7 years ago

I have added to things that might be useful -- I am building a library which many of other projects are using, my problem is I do not want them exposed to properties.Properties data structure directly, please let me know if my code is acceptable. Thought this would be useful to others.

AnirudhVyas commented 7 years ago

going to repush stale changes for pull request.

magiconair commented 7 years ago

@AnirudhVyas A couple of comments:

don't change the formatting. This doesn't look like formatted with gofmt
don't import github.com/magiconair/properties (circular import)
m is already the map you're building in ToMap

I'll look at the rest when you have more changes.

AnirudhVyas commented 7 years ago

that was not a working version ... sorry; committed old changes; will commit soon and update you - thanks for taking time out.