search

magiconair / properties

Java properties scanner for Go
BSD 2-Clause "Simplified" License
323 stars 77 forks source link

Add Map() and FilterFunc() #21

Closed AnirudhVyas closed 7 years ago

AnirudhVyas commented 7 years ago

Please review again and merge.

AnirudhVyas commented 7 years ago

Done

AnirudhVyas commented 7 years ago

blank line - added.

AnirudhVyas commented 7 years ago

Please let me know if there's anything else that is needed; You may choose a better name instead of ToMap( ). Thanks for your help!

magiconair commented 7 years ago

The code looks good. Kids kept me busy today so I didn't get time to think about the name. Did you do any research in the stdlib by any chance? I should have time to merge this tomorrow.

AnirudhVyas commented 7 years ago

Seems like you have handsful - My little one is in love with slides off late; so that kept me busy as well. I'll take a look tomorrow - Thanks.

magiconair commented 7 years ago

There are examples for both ToXXX() and Type() in the stdlib. With the current set of methods I think Map() is a better fit. I'll make the change and merge it.

magiconair commented 7 years ago

I've merged the PR but apparently not in a way that auto-closes this one. :( Attribution is on you, though.

Thanks for the change and your quick replies.