search

magiconair / properties

Java properties scanner for Go
BSD 2-Clause "Simplified" License
323 stars 77 forks source link

Remove assert package from released code #34

Closed elefevre closed 5 years ago

elefevre commented 5 years ago

We use viper on our project, and viper has a dependency with magiconair/properties.

When downloading the code for magiconair/properties, we also get magiconair/properties/assert.

This is an issue, because magiconair/properties/assert is easily confused with testify/assert. In fact, under IntelliJ/Goland, magiconair/properties/assert is generally what is imported by defaulted when typing assert. In fact, we regularly need to remove incorrect references to magiconair/properties/assert.

Is there something that can be done? I'm happy to work on a PR that might offer a fix (presumably by moving files under assert to the main folder, plus changing the name of the assert.go file to something ending in _test.go).

elefevre commented 5 years ago

Hm... it might be that this issue was in earlier versions of dep. I can't seem to be able to reproduce it with newer versions.

For those reading this: use the latest dep and remember to add

[prune]
  unused-packages = true

to your Gopkg.toml.