search

magiconair / properties

Java properties scanner for Go
BSD 2-Clause "Simplified" License
323 stars 77 forks source link

Test failure on 32-bit platforms: "constant 4294967296 overflows int" #7

Closed anthonyfok closed 8 years ago

anthonyfok commented 8 years ago

Detected on armhf by a Debian reproducible build server here:

https://reproducible.debian.net/rb-pkg/unstable/armhf/golang-github-magiconair-properties.html

go test -v github.com/magiconair/properties
# github.com/magiconair/properties
src/github.com/magiconair/properties/properties_test.go:811: constant 4294967296 overflows int
FAIL    github.com/magiconair/properties [build failed]

This happens inside TestPanicOn32BitUintOverflow():

https://github.com/magiconair/properties/blob/master/properties_test.go#L811

This test fails on 32-bit platforms such as armhf, but works fine with 64-bit platforms such as amd64.

Thanks in advance!

Anthony

magiconair commented 8 years ago

This should fix it. Please let me know if it does not. Thx for reporting.

anthonyfok commented 8 years ago

Thank you very much for your prompt response and fix!

I am just responding back to tell you that your fix works perfectly, as seen in the just-completed (20 minutes ago) Debian reproducible build log on armhf below:

https://reproducible.debian.net/rbuild/unstable/armhf/golang-github-magiconair-properties_1.6.0-2.rbuild.log

Cheers, and Merry Christmas!

Anthony