magicstone-dev / acropolis

Community-driven fork of Diaspora's federated social network software
https://magicstone.dev
GNU Affero General Public License v3.0
8 stars 4 forks source link

Problem: CI downloads a schema from a website #106

Closed weex closed 2 years ago

weex commented 2 years ago

In order to validate the name of the software, a schema is downloaded from diaspora.software. This is a problem because it limits development of the software and its forks while also introducing a web call as a point of failure in testing.

Proposed solution: Import the schema file into the codebase and use the local file for validation.

weex commented 2 years ago

Problem was discovered with this PR: https://github.com/magicstone-dev/acropolis/pull/104

weex commented 2 years ago

On further examination it appears the schema is located at vendor/nodeinfo/schemas/1.0.json which makes way more sense.