magicsunday / webtrees-descendants-chart

SVG based descendants chart module for webtrees genealogy application.
GNU General Public License v3.0
26 stars 8 forks source link

Option to display married name of females in chart. #38

Closed zeezhao closed 10 months ago

zeezhao commented 11 months ago

Is your feature request related to a problem? Please describe. Sometimes, there is a need to show the married name of females in the chart, instead of birth name.

Describe the solution you'd like It would be nice to have an option for instance in the "Show more options" section for "Display Married Names". Thanks

magicsunday commented 10 months ago

Fixed in https://github.com/magicsunday/webtrees-descendants-chart/releases/tag/1.5.0

zeezhao commented 10 months ago

Hi - still not working for me. Please see: https://github.com/magicsunday/webtrees-descendants-chart/issues/39#issuecomment-1689998739

edit: I also did a quick test with "Show married names.", and it did not seem to work. Note that I recently fixed married names to use correct GED format, instead of the special field webtrees was using.

magicsunday commented 10 months ago

1.5.0 was corrupt, 1.5.1 should work now.

If it still not working, please provide me a working sample gedcom. In my tree I see the spouses with the married name (2 TYPE married).

zeezhao commented 10 months ago

Thanks. I did try it in 1.5.1 and same issue. Unfortunately, I can't export the gedom but it is definitely using married name (2 TYPE married). Looking at raw gedcom, it is like: 1 NAME XXX /YYY/ .... 1 NAME XXX /ZZZ/ 2 TYPE MARRIED But it displays "XXX YYY" always. Please is it possible the version you released is not taking into the account the flag? It gives me the same result whether "Show married names." is ticked or not.

magicsunday commented 10 months ago

Webtrees displays the first name from the gedcom as the primary name (except there is a different name matching the current locale):

// Generally, the first name is the primary one....
$this->getPrimaryName = 0;
// ...except when the language/name use different character sets
...

Without sample data, I can't reproduce your problem.

In my chart it's working as expected:

zeezhao commented 10 months ago

Thanks for your help. The name type is "birth name". edit: In my example, she is the descendant, so she is shown on top, so opposite to your example above. Her husband is show below.

magicsunday commented 10 months ago

Could you please check, if https://github.com/magicsunday/webtrees-descendants-chart/commit/b288b756bde674fd96f9fd9801c9a83a10d59fa7 fixes your problem?

zeezhao commented 10 months ago

Thank you - this seems to work too! I will do more testing to confirm.

zeezhao commented 10 months ago

This looks fine now. Thank you for your swift response and hard work!