search

magicsunday / webtrees-descendants-chart

SVG based descendants chart module for webtrees genealogy application.
GNU General Public License v3.0
26 stars 8 forks source link

Sort families by date of marriage only if all dates of marriage for spouses at a level are know. If not use the default webtree order. #42

Closed zeezhao closed 10 months ago

zeezhao commented 10 months ago

Describe the bug This is related to the bug I discovered and mentioned here:

https://github.com/magicsunday/webtrees-descendants-chart/issues/39#issuecomment-1689998739

Families are being shown in random order, if marriage date is not filled and unknown.

To Reproduce If any marriage date in a branch at a level is not set, it is causing a random order of families.

Expected behavior The date condition should please be applied to Marriage date too i.e. if any marriage date in a branch at a level is not set, then default to original family order as originally set up in webtrees. Thanks

zeezhao commented 10 months ago

Hi. I can't test this as not got marriage dates. But I suspect it was also related to #39 and #43 issues discovered, that were subsequently fixed. Please confirm. Thanks.