magicsunday / webtrees-descendants-chart

SVG based descendants chart module for webtrees genealogy application.
GNU General Public License v3.0
26 stars 8 forks source link

When birthdate for at least one child not set at a level, please preserve original webtrees order. #43

Closed zeezhao closed 10 months ago

zeezhao commented 10 months ago

Describe the bug When birthdates not set, children at a particular level/tree appear to be sorted randomly.

To Reproduce In a branch where at least one child does not have birthdate set, order of children is random instead of original webtrees order.

Expected behavior When birthdate for at least one child not set at a level, please preserve original webtrees order.

magicsunday commented 10 months ago

Have you tried version 1.5.1? If so, could you please provide me with a GEDCOM example so that I can understand the problem more easily?

zeezhao commented 10 months ago

Yes I have tried v1.5.1. It is the same issue as in previous versions 1.4.1, 1.4.2, 1.5.0.

Unfortunately, I can not provide the GEDCOM file as it is has over 500 individuals and I will have to get permission to export it.

But using my example from #39, when all the children C1, C2, C3, C4 have birthdate set, the sorting by date works as expected.

But :

All records Birth Hide from everyone

edit: In this scenario, they appear to be ordered by death date , when this should not be a factor at all.

magicsunday commented 10 months ago

Could you please check, if https://github.com/magicsunday/webtrees-descendants-chart/commit/e88728625d3a9e6fa3c74fbef26e2e25fbcae66b fixes your problem?

zeezhao commented 10 months ago

Thank you - this seems to work! I will do more testing to confirm.

zeezhao commented 10 months ago

This looks fine now. Thank you for your swift response and hard work!