search

magicsunday / webtrees-fan-chart

SVG based ancestor fan chart module for webtrees genealogy application.
GNU General Public License v3.0
60 stars 19 forks source link

Truncate names #62

Closed SodanWT closed 3 years ago

SodanWT commented 3 years ago

Hi Rico, thank you for your commit concerning the issue #60. I dug a little bit more in the code, and found a way to resolve it without all the fist names being underlined as if they were preferred names. As I am not a developer, my solution is certainly not the right one, so feel free to change whatever you want to keep your quality standard. As this is my first code on GitHub, maybe the pull request is not the right way to share my solution. Just tell me how to do so :)

magicsunday commented 3 years ago

So what was wrong with my fix regarding the preferred first name? If none of the names contains an asterix the first one is used as primary given name. This one gets underlined. Was this not correct?

SodanWT commented 3 years ago

Hi, when there is no preferred name, the first name was underlined. But in webtrees, only the preferred names are underlined, so this made confusion with the other pages of webtrees. The other reason is that names were truncated starting with the first ones leaving the last ones unchanged if not necessary, but the last ones are the less known so they should be the first to be truncated.

SodanWT commented 3 years ago

I see that my commit 9444e5b8def4ad780efba63b2753fbfeb85d3cc1 has been included in the pull request, this was not intended. Dismiss it. I'll check how to remove it.

SodanWT commented 3 years ago

The new fix for #60 by @magicsunday is way better than mine. Happy to close this pull request