magicsunday / webtrees-fan-chart

SVG based ancestor fan chart module for webtrees genealogy application.
GNU General Public License v3.0
59 stars 18 forks source link

Surnames truncated in outer generations #66

Closed reteP-riS closed 3 years ago

reteP-riS commented 3 years ago

With version 2.2.0 I observe several individuals in generation 8, 9 and 10 where the surname is being abbreviated either instead of the last firstname or additionally to the last firstname being abbreviated. This seems to occur regardless of whether a preferred first name exists or not. Everything looks ok for generation 7 and lower. I can't test beyond generation 10. Examples:

magicsunday commented 3 years ago

Last names are now truncated last.

The fan diagram is limited to 10 generations, as there would no longer be enough space in an 11th generation for the names to be displayed.

reteP-riS commented 3 years ago

I only downloaded ./webtrees-fan-chart/resources/js/fan-chart.min.js to test the fix and the issue seems to be resolved. Unfortunately now the birth, marriage and death symbols ∗, ⚭ and † are replaced by a question mark. Is that a new issue or should I wait for a new release to get the full package of changes?

Thank you anyway. Excellent module!

magicsunday commented 3 years ago

This is strange, it does not happen in my test environment.

reteP-riS commented 3 years ago

The new issue with the birth, marriage and death symbols ∗, ⚭ and † being replaced by a question mark exists on different browsers. So I think that I need to get the full package of changes. It would be very much appreciated if you could create a new release.

reteP-riS commented 3 years ago

That new issue is resolved now. Something had gone wrong with the file format when I copied ./webtrees-fan-chart/resources/js/fan-chart.min.js. Thanks again!