magicuidesign / magicui

UI Library for Design Engineers. Animated components and effects you can copy and paste into your apps. Free. Open Source.
https://magicui.design
MIT License
12.08k stars 484 forks source link

Feat:Add Support for Profile Links in AvatarCircles Component #326

Closed sanjay-mali closed 1 week ago

sanjay-mali commented 2 months ago

fix #305

Changes Made

Usage

To utilize this feature, update the avatarUrls prop with an array of objects, where each object includes:

vercel[bot] commented 2 months ago

@sanjay-mali is attempting to deploy a commit to the product-studio Team on Vercel.

A member of the Team first needs to authorize it.

sanjay-mali commented 2 months ago

Any update?

itsarghyadas commented 2 weeks ago

@sanjay-mali Are you addressing two different issues here? Any changes made to the hero-video-dialog component should be in a separate PR, as it should address a different issue, right? I understand the changes made for Avatar, but could you clarify what changes you're making to the hero-video-dialog component?

sanjay-mali commented 2 weeks ago

@itsarghyadas Yes, you are correct that changes to the hero-video-dialog component should ideally be in a separate PR. However, in this particular PR, the changes to hero-video-dialog are as follows:

Dynamic Gradient Background- I added functionality to allow dynamic background gradients based on the startColor and endColor props. Previously, the component only used a fixed gradient (from-primary/30 to-primary). Now, it checks whether the provided colors are valid Tailwind colors or custom ones and applies them accordingly.

I hope that clarifies the changes. Let me know if you'd like me to split this into a separate PR or if you need further refinements.

dillionverma commented 2 weeks ago

Hey great changes! :) Having separate PRs for this would be helpful for us to review and merge easily!

sanjay-mali commented 2 weeks ago

@dillionverma Thank you! I completely understand. I'll go ahead and create a separate PR for the changes to the hero-video-dialog component so it's easier to review and merge. I'll get that done shortly! šŸ˜Š

Let me know if there's anything else I can assist with!

sanjay-mali commented 2 weeks ago

Hey @dillionverma , I created a separate PR as you suggested. Please check #417 and let me know if the changes look good. Should we go ahead and close this PR?

itsarghyadas commented 1 week ago

@sanjay-mali Iā€™m reviewing that right now. Thanks for the extra work! You can close this PR and create or update this one for your proposed changes to the hero-video-dialog component.

sanjay-mali commented 1 week ago

@itsarghyadas Thank you šŸ˜Š