search

magicuidesign / magicui

UI Library for Design Engineers. Animated components and effects you can copy and paste into your apps. Free. Open Source.
https://magicui.design
MIT License
12.11k stars 485 forks source link

refactor: optimize AnimatedList component #334

Closed gokh4nozturk closed 2 weeks ago

gokh4nozturk commented 2 months ago

Fix: Animated List

Pulled from issues: https://github.com/magicuidesign/magicui/issues/333

vercel[bot] commented 2 months ago

@gokh4nozturk is attempting to deploy a commit to the product-studio Team on Vercel.

A member of the Team first needs to authorize it.

gokh4nozturk commented 2 weeks ago

So what it does basically - stop the animation after all the items are shown?

Yes @itsarghyadas

itsarghyadas commented 2 weeks ago

@gokh4nozturk thanks for the reply. So if I’m understanding correctly, after displaying all the notifications for a set time, the animation just stops until you refresh the page. Is that correct?

Also, could you explain how this optimizes the functionality and what specific error you saw, as mentioned in the issue https://github.com/magicuidesign/magicui/issues/333

itsarghyadas commented 2 weeks ago

Why do you think the animation stopping when the number of elements runs out is expected? Just trying to understand your perspective.

itsarghyadas commented 2 weeks ago

We discussed this internally, and I’ve reviewed it. This PR is good to go. Thanks for the contribution!