search

magicuidesign / magicui

UI Library for Design Engineers. Animated components and effects you can copy and paste into your apps. Free. Open Source.
https://magicui.design
MIT License
12.08k stars 484 forks source link

[Bug] /docs/components/rainbow-button #359

Closed subhadip001 closed 1 month ago

subhadip001 commented 1 month ago

Bug Description While passing custom classNames with the New Rainbow button component it removes/ overrides the animation

To Reproduce Steps to reproduce the behavior:

  1. Install the new Rainbow button with CLI
  2. Use it in project (Animation will show)
  3. Add className to it as props
  4. Notice the button becomes animationless

Expected behavior While using with the className props like this <RainbowButton className="p-2 flex gap-2">{children}</RainbowButton>; It should combine with the animation.

Screenshots

Screenshot 2024-10-06 at 4 01 10 PM

Desktop (please complete the following information):

Additional context Btw I have figured it out and solved the issue for my project. If needed i can fix this also.

dillionverma commented 1 month ago

thanks for pointing this out! just pushed a fix for this in latest commit :)

https://github.com/magicuidesign/magicui/commit/33b2067637337995102817e3b5c03178d0b9f448