search

magicus / ModSettings

Provides an easy to access configuration screen for all installed mods
MIT License
9 stars 1 forks source link

Incompatible with Minimal Menu #5

Closed Zoey2936 closed 2 years ago

Zoey2936 commented 2 years ago

image

When I remove the Minimal Menu Mod (https://www.curseforge.com/minecraft/mc-mods/minimal-menu) or the Mod settings Mod, the main menu looks normal, so I think the Mod settings Mod and the Minimal Menu Mod are incompatible

magicus commented 2 years ago

It is likely that they just are incompatible. Having multiple mods modifying the main menu is conflict prone. With that said, I'll have a look at Minimal Menu to see if there's anything I can do to improve interaction.

JustAnOkapi commented 2 years ago

I have the same problem and it seems to also be the same two mods

magicus commented 2 years ago

@2020Sanoj What solution would you expect/prefer when combining Minimal Menu (which removes menu buttons) and Mod Settings (which adds butttons)? If you get one wide "Mod Settings" button at the end of the list, would that be acceptable?

JustAnOkapi commented 2 years ago

I would say removing the wide one and fixing the options button placement.

Zoey2936 commented 2 years ago

I accept any solution, as log as the main screen don't have buttons duplicated or on random positions. So do that what the easiest option for you is.

yesn0t commented 2 years ago

just wanted to say that i use both mods on 1.17.1 and they work well together,
modsettings 1.0.0 and minimalmenu 0.0.7
potentially noteworthy : 0.0.7 was the last minimalmenu version for 1.17 and it didn't use cloth config, so i suppose major changes happened between that and current 1.0+ versions of minimalmenu

magicus commented 2 years ago

I think I have a solution to this now. It fixes all apparent problems, anyway. But the test matrix is large with all possible adjustments in Minimal Menu, combined with how Mod Menu can be instructed to place its "Mods" button, so it will not look nice in all combinations. (Not just my fault; try Mod Menu "adjacent" placement, combined with "Remove Realms" in "Minimal Menu" ... ugh)