search

magit / forge

Work with Git forges from the comfort of Magit
GNU General Public License v3.0
1.3k stars 113 forks source link

Edit pull request description does not update forge's GUI #664

Closed jroimartin closed 4 months ago

jroimartin commented 4 months ago

Expected behavior

  1. Open pull request
  2. Edit description with "C-c C-e"
  3. Update description and apply with "C-c C-c"
  4. The pull request description buffer is closed, the pull request details are updated in forge's GUI and the description is updated in GitHub

Observed behavior

  1. Open pull request
  2. Edit description with "C-c C-e"
  3. Update description and apply with "C-c C-c"
  4. The pull request description buffer is not closed and the pull request details are not updated in forge's GUI. However, the description is updated GitHub

Environment GNU Emacs 29.3 (build 1, x86_64-redhat-linux-gnu, GTK+ Version 3.24.41, cairo version 1.18.0) of 2024-03-25 forge 20240502.1252 magit 20240503.753

tarsius commented 4 months ago

That command is part of the current refactor. That version works and the whole thing will likely be ready in a few days, maybe a week [edit: maybe longer].

tarsius commented 4 months ago

Actually it's not part of that. But when I just tried to reproduce the issues, I couldn't.

However I have noticed something like that myself recently, and know what I have to test. (Basically we first use the issue api endpoint and if that fails the pull-request endpoint. I suspect the error we receive if the first request fails is not consistent, but will have to look into it more.) [Also, here we probably could go straight for the pr endpoint, but there are cases where that is not possible.] {{And all that might we wrong to, just trying to correct the mistake from the previous quick reply, and digging myself in deeper. So let's scratch all that and just say, I'll look into it, thanks for reporting.}}

jroimartin commented 4 months ago

Thanks! If I can help with any test, just tell me.

tarsius commented 4 months ago

This should work now. This depends on changes to Ghub, so you'll have to update that too.