magit / forge

Work with Git forges from the comfort of Magit
GNU General Public License v3.0
1.31k stars 116 forks source link

error viewing issues after updating to the latest forge and closql versions #680

Closed benthamite closed 3 months ago

benthamite commented 3 months ago

After updating to the latest version of forge (0102834) and to the latest version of closql (0386b7f), attempting to add a new repository via n a a in that repo’s Magit buffer produced this error

Debugger entered--Lisp error: (emacsql-syntax "Invalid identifier: (issue-assignee assignee)")
emacsql-error("Invalid identifier: %S" (issue-assignee assignee))
emacsql-escape-identifier((issue-assignee assignee))
emacsql-format(("PRAGMA table_info(%s)" (0 . :identifier)) (issue-assignee assignee))
emacsql-compile(#<emacsql-sqlite-builtin-connection emacsql-sqlite-builtin-connection-cd406fc6> [:pragma (funcall table-info $i1)] (issue-assignee assignee))
apply(emacsql-compile #<emacsql-sqlite-builtin-connection emacsql-sqlite-builtin-connection-cd406fc6> [:pragma (funcall table-info $i1)] (issue-assignee assignee))
#f(compiled-function (connection sql &rest args) #<bytecode 0x18572345793ecd6a>)(#<emacsql-sqlite-builtin-connection emacsql-sqlite-builtin-connection-cd406fc6> [:pragma (funcall table-info $i1)] (issue-assignee assignee))
apply(#f(compiled-function (connection sql &rest args) #<bytecode 0x18572345793ecd6a>) #<emacsql-sqlite-builtin-connection emacsql-sqlite-builtin-connection-cd406fc6> ([:pragma (funcall table-info $i1)] (issue-assignee assignee)))
emacsql(#<emacsql-sqlite-builtin-connection emacsql-sqlite-builtin-connection-cd406fc6> [:pragma (funcall table-info $i1)] (issue-assignee assignee))
apply(emacsql #<emacsql-sqlite-builtin-connection emacsql-sqlite-builtin-connection-cd406fc6> [:pragma (funcall table-info $i1)] (issue-assignee assignee))
#f(compiled-function (db sql &rest args) #<bytecode 0x16db9cb04e2c4b54>)(#<forge-database forge-database-4c9e20ae> [:pragma (funcall table-info $i1)] (issue-assignee assignee))
apply(#f(compiled-function (db sql &rest args) #<bytecode 0x16db9cb04e2c4b54>) #<forge-database forge-database-4c9e20ae> ([:pragma (funcall table-info $i1)] (issue-assignee assignee)))
emacsql(#<forge-database forge-database-4c9e20ae> [:pragma (funcall table-info $i1)] (issue-assignee assignee))
closql--table-columns(#<forge-database forge-database-4c9e20ae> (issue-assignee assignee))
closql-dref(#<forge-issue forge-issue-ca5eb87c> assignees)
closql-oref(#<forge-issue forge-issue-ca5eb87c> assignees)
#f(compiled-function (db obj &optional replace) #<bytecode -0x2ea506641692d40>)(#<forge-database forge-database-4c9e20ae> #<forge-issue forge-issue-ca5eb87c>)
apply(#f(compiled-function (db obj &optional replace) #<bytecode -0x2ea506641692d40>) #<forge-database forge-database-4c9e20ae> #<forge-issue forge-issue-ca5eb87c>)
closql-insert(#<forge-database forge-database-4c9e20ae> #<forge-issue forge-issue-ca5eb87c>)
<...>

This error disappeared after I restarted Emacs. However, upon successfully adding the new repo, I get another error when I try to view any of its issues via forge-visit-this-topic (RET):

Debugger entered--Lisp error: (wrong-number-of-arguments #<subr magit-setup-buffer-internal> 5)
magit-setup-buffer-internal(forge-issue-mode t ((forge-buffer-topic #<forge-issue forge-issue-cbf55cea>)) "*forge: tlon-team/sandbox #19*" "/Users/pablostafforini/Library/CloudStorage/Dropbox/repos/sandbox/")
forge-topic-setup-buffer(#<forge-issue forge-issue-cbf55cea>)
#<subr forge-visit-this-topic>(nil)
apply(#<subr forge-visit-this-topic> nil)
forge-visit-this-topic(nil)
funcall-interactively(forge-visit-this-topic nil)
command-execute(forge-visit-this-topic)

(I mention the initial error in case it helps with debugging.)

GNU Emacs 29.3 (build 2, aarch64-apple-darwin23.2.0, NS appkit-2487.30 Version 14.2.1 (Build 23C71)) of 2024-04-26

tarsius commented 3 months ago

You'll need to update to the latest magit snapshot (https://github.com/magit/magit/commit/e2876c8bc9d92443488bb73ffb0d4281023d0d74).

benthamite commented 3 months ago

I see, thanks.