search

magit / with-editor

Use the Emacsclient as the $EDITOR of child processes
http://magit.vc/manual/with-editor
GNU General Public License v3.0
185 stars 45 forks source link

*ERROR*: Wrong number of arguments: (1 . 4), 5 #82

Closed tsdh closed 3 years ago

tsdh commented 3 years ago

This bug report is the counterpart of the emacs report https://debbugs.gnu.org/cgi/bugreport.cgi?bug=43716 which I reported before I knew that the error is in with-buffer.el.

I've debugged the issue (see https://debbugs.gnu.org/cgi/bugreport.cgi?bug=43716#41). The short version is that the signature of server-switch-buffer changed recently on the emacs master branch so that the with-editor advice server-switch-buffer--with-editor-server-window-alist has too few arguments which gives "ERROR: Wrong number of arguments: (1 . 4), 5" when doing emacsclient some-file.txt.

tsdh commented 3 years ago

Thanks Jonas, that was quick! :+1:

gvol commented 3 years ago

Thanks to both of you for this! I was trying to debug it myself and eventually gave up and tried updating packages on MELPA and it was magicly (magitly?) fixed!

andrelkin commented 3 years ago

It was somewhat really difficult to me to find this one. So it was cased for me by trying out magit - which is cool :-), but i did not realize at once that with-editor is a stand-alone package.

Here it would be good to state that explicitly: please upgrade with-editor.

Thank you for fixing it!