search

magjac / d3-graphviz

Graphviz DOT rendering and animated transitions using D3
BSD 3-Clause "New" or "Revised" License
1.68k stars 103 forks source link

Install updates #240

Closed mrdrogdrog closed 2 years ago

mrdrogdrog commented 2 years ago

Hello,

We use this lib at https://github.com/hedgedoc/react-client and can't update @hpcc-js/wasm because of this package. Therefore I've created this PR.

This PR does two things:

Please merge it and publish a new release :)

mrdrogdrog commented 2 years ago

Huh. That's weird. On my machine the tests are running fine 🤔 I'll investigate that.

magjac commented 2 years ago

Just try re-running it. I've seen this kind of flakiness before.

mrdrogdrog commented 2 years ago

I've updated the commit

mrdrogdrog commented 2 years ago

The tests aren't running with Node 12. If you're okay with it then I would remove node 12 from the CI config. Its end of life was 4 months ago. https://endoflife.date/nodejs

magjac commented 2 years ago

I think the tests needs to be updated with respect to https://gitlab.com/graphviz/graphviz/-/merge_requests/2472.

magjac commented 2 years ago

@mrdrogdrog While working on porting d3-graphviz to D3 v7 I got hit by the failing tests due to https://gitlab.com/graphviz/graphviz/-/merge_requests/2472 so I updated the test data and pushed three commits to https://github.com/magjac/d3-graphviz/tree/update in case you want to rebase or cherry-pick them.

mrdrogdrog commented 2 years ago

@magjac

Okay. Everythings seems to be in order (at least locally). Let's try again.

codecov[bot] commented 2 years ago

Codecov Report

Merging #240 (1035a03) into master (8b60cbb) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #240   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines         1114      1114           
=========================================
  Hits          1114      1114

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mrdrogdrog commented 2 years ago

Seems like everything is okay now

magjac commented 2 years ago

I fixed one of my own spelling mistakes and merged. Thank you so much for doing this :slightly_smiling_face:

mrdrogdrog commented 2 years ago

Thank you for creating and maintaining this lib! ☺️