codecov[bot] commented 2 years ago

Codecov Report

Merging #242 (e7509e6) into master (3630ed9) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head e7509e6 differs from pull request most recent head ab08920. Consider uploading reports for the commit ab08920 to get more accurate results

@@             Coverage Diff             @@
##            master      #242     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           37        39      +2     
  Lines         1114      2282   +1168     
===========================================
+ Hits          1114      2282   +1168

Impacted Files	Coverage Δ
index.js	`100.00% <100.00%> (ø)`
src/dot.js	`100.00% <100.00%> (ø)`
src/drawEdge.js	`100.00% <100.00%> (ø)`
src/drawNode.js	`100.00% <100.00%> (ø)`
src/graphviz.js	`100.00% <100.00%> (ø)`
src/render.js	`100.00% <100.00%> (ø)`
src/selection/graphviz.js	`100.00% <100.00%> (ø)`
src/selection/index.js	`100.00% <100.00%> (ø)`
src/svg.js	`100.00% <100.00%> (ø)`
src/workerCode.js	`100.00% <100.00%> (ø)`
... and 38 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mcmartins commented 1 year ago

@magjac are you planning to merge and release this soon(ish)?

Thanks!

magjac commented 1 year ago

Yes, but I have a few test cases that do not pass yet which I need to figure out how to fix first. Hopefully I can carve out some time for this during this week.

magjac commented 1 year ago

Right now I'm on a detour in the https://github.com/magjac/d3-graphviz/tree/DEBUG-upgrade-to-d3-version-7 branch.

mcmartins commented 1 year ago

Awesome @magjac !

magjac / d3-graphviz

Upgrade to d3 version 7 and adopt type=module #242

Codecov Report