search

magjo21 / capstone-project

https://capstone-project-magjo21.vercel.app
1 stars 0 forks source link

Feature/overview #19

Closed magjo21 closed 1 year ago

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
capstone-project ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 9, 2023 at 11:11AM (UTC)
magjo21 commented 1 year ago

Hey Magnus, this looks quite clever I like it a lot! I added some change requests, have a look!

Hello Felix, thanks for your opinion, I will have a look at it. but first I would like to get a little further in the code. would be great if you could give me the aprove

F-Kirchhoff commented 1 year ago

Hey Magnus, I think these changes are necessary right now. I already gave you 90% of the solution. I think you will be done with it fast.

magjo21 commented 1 year ago

Hey Magnus, I think these changes are necessary right now. I already gave you 90% of the solution. I think you will be done with it fast.

Hello, I get the point, I have also already taken 2 of your comments so I would like to leave it at that.

F-Kirchhoff commented 1 year ago

Hey Magnus, I get it that you want to continue on your other interesting features. But change requests from Coaches are not optional. I won't approve this PR if only part of the changes are implemented. Thank you for understanding.

magjo21 commented 1 year ago

Hey Magnus, I get it that you want to continue on your other interesting features. But change requests from Coaches are not optional. I won't approve this PR if only part of the changes are implemented. Thank you for understanding.

Hey Felix, thank you for your suggestion. I have implemented it as well as possible. If you have any other changes let me know.✌️