search

magland / ml_ms4alg

MountainSort v4
7 stars 19 forks source link

updated to new spikeextractors 0.4.0 #14

Closed alejoe91 closed 5 years ago

alejoe91 commented 5 years ago

@magland we are refractoring spikeinterface to snake case. This patch updates the calls to spikeextractors objects to the new functions.

For now spiketoolkit tests pass because we install my patched fork, so no rush :)

tjd2002 commented 5 years ago

@magland Do we want to cut a new release for this?

magland commented 5 years ago

Thanks Tom. I just bumped the version and pushed -- so hopefully travis publishes the new version. Jeremy

On Mon, May 6, 2019 at 4:22 PM Tom Davidson notifications@github.com wrote:

@magland https://github.com/magland Do we want to cut a new release for this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/magland/ml_ms4alg/pull/14#issuecomment-489762479, or mute the thread https://github.com/notifications/unsubscribe-auth/AA4CIQGEZRHRHON5AA5KEJLPUCHQJANCNFSM4HD3FUIA .

tjd2002 commented 5 years ago

I think we also need to add the dependency on 'spikeextractors' back to the setup.py file, since this patch removes the plug_spikeextractors copy of that code.

magland commented 5 years ago

okay, could you do that, pls?

On Mon, May 6, 2019 at 4:39 PM Tom Davidson notifications@github.com wrote:

I think we also need to add the dependency on 'spikeextractors' back to the setup.py file, since this patch removes the plug_spikeextractors copy of that code.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/magland/ml_ms4alg/pull/14#issuecomment-489767955, or mute the thread https://github.com/notifications/unsubscribe-auth/AA4CIQDOPBAGB2U4XUYA7X3PUCJORANCNFSM4HD3FUIA .

tjd2002 commented 5 years ago

Yup!

Sent from my phone

On May 6, 2019, at 1:42 PM, Jeremy Magland notifications@github.com wrote:

okay, could you do that, pls?

On Mon, May 6, 2019 at 4:39 PM Tom Davidson notifications@github.com wrote:

I think we also need to add the dependency on 'spikeextractors' back to the setup.py file, since this patch removes the plug_spikeextractors copy of that code.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/magland/ml_ms4alg/pull/14#issuecomment-489767955, or mute the thread https://github.com/notifications/unsubscribe-auth/AA4CIQDOPBAGB2U4XUYA7X3PUCJORANCNFSM4HD3FUIA .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.