search

magland / ml_ms4alg

MountainSort v4
7 stars 19 forks source link

Version in __version__ #22

Open samuelgarcia opened 4 years ago

samuelgarcia commented 4 years ago

Hi Jeremy. Could you had a version attributes in ml_ms4alg, so the version could be introspected from spikesorters ?

We need to report version for benchmark.

At the moment  python spikesorters.print_sorter_version()   give 

herdingspikes: unknown
ironclust: 5.0.8
kilosort: unknown
kilosort2: unknown
klusta: 3.0.16
mountainsort4: unknown
spykingcircus: 0.9.0
tridesclous: 1.4.2

Cheers

samuelgarcia commented 4 years ago

https://github.com/MouseLand/Kilosort2/issues/182

https://github.com/magland/ml_ms4alg/issues/22

https://github.com/flatironinstitute/ironclust/issues/39

alejoe91 commented 4 years ago

https://github.com/magland/ml_ms4alg/pull/23