search

magland / sortingview

Web app for viewing results of ephys spike sorting
Apache License 2.0
25 stars 8 forks source link

Errors in autocorrelation calculation /display #11

Closed lfrank closed 3 years ago

lfrank commented 3 years ago

In some cases a unit's autocorrelation can be very strange:

Screen Shot 2021-07-05 at 6 21 54 PM

Here's the link to the workspace: https://sortingview.vercel.app/workspace/sorting/R-1ac0e7153ac0/S-b5b3168133d0?workspace=1a89e449d88d217fb77be62fac75bbde66adec69f83969c3019f33e03c436c6c&channel=franklab

magland commented 3 years ago

This was an integer overflow error. I fixed it, but you need to upgrade sortingview to 0.2.13.

(There's a bit of a difficulty with this flow, where the front-end version needs to match with the back-end version. We'll need to work out how best to manage this. Right now, both should be at 0.2.13)

magland commented 3 years ago

This appears to still be a problem -- i will continue to investigate.

magland commented 3 years ago

I believe this should be fixed once you've upgraded to >= 0.2.17 on the backend

@lfrank @khl02007

magland commented 3 years ago

I can confirm this has been fixed (same link as above):

image