Closed acomrie closed 2 years ago
@acomrie. I think we can do this. Here are the considerations.
The reason for the limit is to avoid excessive queuing of tasks for computing data (it takes more tasks to retrieve a larger time interval). This is mainly relevant for the timeseries view (raw traces) - much more so than the spike amplitude view.
But the spike amplitude and timeseries views are synchronized. So it's difficult to have a separate limit for the two views. But I wonder if this can be achieved in a nice way. Here's what I propose:
What do you think @acomrie, @rsnevers, @jsoules ?
That makes sense and sounds good. I especially like the idea to add a message to alert the user to the zoom limit.
Another idea would be to control whether the two views are timelocked by a toggle button like the one in the xcorr view that controls unit selection. Sortingview could alert the user that the two views (timeseries and spike amplitude) need to be unlocked to allow further zoom out of the spike amplitude view. That wouldn't have much added benefit over what you already proposed though, other than potentially allowing more views to simultaneously be open and displayed with independent time axes, and seems more difficult to implement. So, probably still makes sense to go with your suggestion!
A request on behalf of @rsnevers and I -- it would be nice to be able to fully zoom out of the spike amplitude view to see spikes from the full length of the recording. The zoom out button seems to max out at a point where a user can still scroll left to right through time, like so -
Yet it also seems like a user can edit the time range at the bottom to a falsely large upper limit, and force this fully zoomed out display -
@rsnevers does that align with your experience?
Wondering if there is any reason not to enable fully zooming out with the zoom-out button? If not, would be great to enable that. It can be helpful to see super slow timescale changes in spike amplitude that occur over the course of a few hours of a recording in this zoomed out view. Thanks in advance for your thoughts.