search

magland / sortingview

Web app for viewing results of ephys spike sorting
Apache License 2.0
25 stars 8 forks source link

int16 extractor issues #152

Closed lfrank closed 3 years ago

lfrank commented 3 years ago

Using an int16 extractor seems faster (and certainly reduces files sizes, which is very helpful) but also causes various division by zero errors in sorting view:

https://www.figurl.org/fig?channel=franklab2&figureObject=9c35a6a5ea204bcaf37e7a4695991801b4eb51b3&label=despereaux20191125_.nwb_02_r1_2

magland commented 3 years ago

I was not able to reproduce. Could you please specify which views exactly are giving the divide-by-zero errors?

lfrank commented 3 years ago

Sorry for not specifying.

And now everything calculates correctly, which makes me wonder if it might be due to different versions of the sortingview backend on our side. I’ll investigate when I can.

On Sep 30, 2021, at 4:39 AM, Jeremy Magland @.***> wrote:

Could you please specify which views exactly are giving the divide-by-zero errors?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/magland/sortingview/issues/152#issuecomment-931243526, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABV4PSLA3EXTVBMMQ475GHLUEREA5ANCNFSM5FBKSOFQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

magland commented 3 years ago

Closing. Feel free to reopen if needed.