search

magland / sortingview

Web app for viewing results of ephys spike sorting
Apache License 2.0
25 stars 8 forks source link

Unit numbers for unit waveforms #39

Closed magland closed 2 years ago

magland commented 3 years ago

transferred from: https://github.com/flatironinstitute/labbox-ephys/issues/472

magland commented 3 years ago

Copied from labbox-ephys issue:

On the waveform display, the unit numbers could go much closer to the top left electrode circle to save space.

magland commented 3 years ago

@lfrank, not sure I can reproduce. See screenshot: image

Could you provide a screenshot showing the wasted space?

lfrank commented 3 years ago

I can’t generate one right now, but do you have a tetrode version you could try? That was where there was quite a lot of extra space.

On Jul 22, 2021, at 8:26 AM, Jeremy Magland @.***> wrote:

@lfrank https://github.com/lfrank, not sure I can reproduce. See screenshot: https://user-images.githubusercontent.com/3679296/126665303-eff38e56-df69-4d2e-85b3-0b44f02697c5.png Could you provide a screenshot showing the wasted space?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/magland/sortingview/issues/39#issuecomment-885003271, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABV4PSLLRYVTYHJLRAI7H63TZA2A3ANCNFSM5AV2M2ZQ.

magland commented 3 years ago

Is this the kind of thing you were seeing?

image

I do see there is extra space in some cases.

lfrank commented 3 years ago

Yes, although it might have been more pronounced in the Jupyter widget. In any case, having the Unit numbers closer to the traces and (in a perfect world) having an option for displaying these in a row (as in mountainview) would be great.

Is this the kind of thing you were seeing?

https://user-images.githubusercontent.com/3679296/126690848-a0d51846-6885-47b4-86e5-e51dac1dc85b.png I do see there is extra space in some cases.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/magland/sortingview/issues/39#issuecomment-885142301, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABV4PSJDDPPZJX36JRXAJVTTZBQAJANCNFSM5AV2M2ZQ.