search

magland / spikesortingview

Figurl views of spike sorting results
Apache License 2.0
1 stars 0 forks source link

time interval annotations #143

Closed magland closed 2 years ago

magland commented 2 years ago

Addresses #138

135 and #140 are merged into this PR

Add to annotations window a section for time interval annotations. Those are like timepoint annotations, except you have a [number, number] interval rather than a single number timepoint.

Similar behavior as timepoint annotations. Click, shift+click to select a time interval, then click "ADD TIME INTERVAL" to add that annotation. Internally it is stored with all the annotations as type "time-interval".

When saving annotations, it saves both timepoint and time-interval annotations in one big list.

TimeScrollView shows both timepoint and time interval annotations in the TSVAnnotationLayer.

Clicking on a time interval annotation selects that interval, and moves to the center of the interval if not already visible. Had to add some more actions and modify the reducer for recording selection in order to accomplish that. Everything has its correspondence with focusTime <-> focusTimeInterval.

magland commented 2 years ago

See it in action: https://www.figurl.org/f?v=gs://figurl/spikesortingview-9-annotation-dev&d=sha1://7719fce3538437c9e739692bef2f9d1cd0118b8f&label=Timeseries%20graph%20example&s={%22annotations%22:%22sha1://c62e51ed8573b2be668283dca9139be605d8e504%22}

jsoules commented 2 years ago

Is it just me, or are the saved timepoints not rendering on this link?

magland commented 2 years ago

Oh that's because they were out-of-range for some reason. Try this:

https://www.figurl.org/f?v=gs://figurl/spikesortingview-9-annotation-dev&d=sha1://7719fce3538437c9e739692bef2f9d1cd0118b8f&label=Timeseries%20graph%20example&s={%22annotations%22:%22sha1://b725b7b44a0ed38c50c3b4a7f3ee7dd8d9f4d3d2%22}

magland commented 2 years ago

Sorry, forgot I had this pending to review. Off to a meeting now.

I think you can merge this if you like, but if you want to hold off for a little bit I can get you a PR to fix issue #142 first. Could probably have it by tomorrow morning--up to you if you want to get this out the door first.

I'll merge now. #142 I think is worthy of its own PR