search

maglevhq / maglev-core

Ruby on Rails website builder
https://www.maglev.dev
MIT License
273 stars 47 forks source link

Rails 7.1 support #66

Closed code-bunny closed 11 months ago

code-bunny commented 11 months ago

Seems the gem is a wee bit fussy with Rails versions as I needed to fork it for a Rails 7.1 project. I haven't ran into any issues with functionality so I propose you push up the gem spec requirements.

did commented 11 months ago

@code-bunny thanks for the reminder 👍 Actually, it requires a little more work than just pushing up the gem spec requirement. I had to fix some warnings (easy) but I also found a nasty bug with the uploading of assets. Long story short, we analyse the newly uploaded file before it gets persisted by the storage service leading to an exception. I found a solution but it doesn't work every time. I'm on it.

code-bunny commented 11 months ago

I haven't found any errors in uploading assets, but there is the occasional hiccup when it comes to saving a url for the nav. If I find any bugs I'll be sure to PR the fixes.

did commented 11 months ago

@code-bunny sorry to bother you but could you open an issue for the saving an url for the nav issue please? thanks!

did commented 11 months ago

@code-bunny I've release the 1.4.0 version of the gem. This version can be installed in a Rails 7.1 application.