search

maglnet / ComposerRequireChecker

A CLI tool to check whether a specific composer package uses imported symbols that aren't part of its direct composer dependencies
MIT License
901 stars 73 forks source link

Replace VFS Stream with spatie temp directory #512

Closed fredden closed 8 months ago

fredden commented 9 months ago

I encountered an incompatibility with the test-suite, where real files weren't being used to run the tests. This works fine most of the time, but this is not compatible with the changes in #511. I've put these changes in a separate pull request so they can be evaluated separately from #511. There should be no changes to functionality nor test coverage with this pull request.

fredden commented 9 months ago

I've clearly failed to test this on Windows. I'll review and update this when I have time.

Ocramius commented 9 months ago

@fredden btw, observing your regular pushes and understanding your frustration: filesystems are hard.

Also, I wish we never supported .phar to begin with ;_;

fredden commented 9 months ago

@Ocramius I think this pull request is ready for review.