search

magma / S1APTester

A test tool that simulates the s1aptest functionality of a LTE network
Other
54 stars 43 forks source link

Revert "resolved compilation error of Test Controller Stub" #24

Closed ssanadhya closed 4 years ago

ssanadhya commented 4 years ago

Reverts facebookexperimental/S1APTester#22

The code compilation is failing with these changes, so reverting this commit.

vimal2828 commented 4 years ago

@ssanadhya , can you please share the compilation error because I pushed the change after making sure code is compiling in local machine.
The changes I pushed it was related to structure definition where "r" was used in place of "u" for union, this was causing compilation error for TestCntlrStub. And also using "r" for union is wrong because in all other places it is "u".

vimal2828 commented 4 years ago

@ssanadhya , in the file fw_api_int.x , I found most of the places "u" is used for union in the api definition. There are one or two places where it seems naming conversion is not followed and skipped in review earlier. I think it should be consistent and after making consistent in API file, it will break the compilation of other components which are using this library.

Showing inconsistent coding style from the same file fw_api_int.x.

typedef struct uepdnConRsp { U8 ue_Id; U8 status; union { pdnConRejInfo_t conRejInfo; Ue_Pdn_Info pdnInfo; }m; }uePdnConRsp_t;

typedef struct _resetReq { resetType rstType; ResetCause cause; union { CompleteReset completeRst; PartialReset partialRst; }r; }ResetReq;

typedef struct _fwNbMmeConfigTrnsf { union { U8 req; U8 reply; }u; }FwNbMmeConfigTrnsf_t;

Most of the places it is "u" in two places it is "r" and "m". I believe first we should correct this one.