magma / domain-proxy

A Domain proxy for Magma
BSD 3-Clause "New" or "Revised" License
1 stars 6 forks source link

Domain Proxy NMS UI still active when Domain Proxy module is disabled in deployment #469

Closed xbend closed 2 years ago

xbend commented 2 years ago

As reported, the Domain Proxy UI functionality is still active even if domain proxy has been disabled in deployment helm charts. Please note, Domain Proxy module is disabled by default, and requires manual enabling per environment deployment. However NMS UI implementation for Domain Proxy remains always present.

Suggested options are:

Approach: Investigate internally if suggestions can be applied and are consistent with similar cases in Magma. If not, extend discussion to Magma NMS community to figure out best approach.

thmsschmitt commented 2 years ago

@xbend It would be good to have this fixed before the 1.8 release otherwise everybody will constantly get those CBSD errors.

xbend commented 2 years ago

@thmsschmitt Is there a timeline for creating the 1.8 branch? How much time do we have to fix the issue?

thmsschmitt commented 2 years ago

That is a question that can be better answered by other people. Let's have this discussion in Slack, I'll raise it in the relevant channel. Imho we could also implement a simple solution first e.g. suppress the error and come up with a proper fix later.

Neudrino commented 2 years ago

Let's have this discussion in Slack

E.g. the #magma-releases channel with this post.

Neudrino commented 2 years ago

https://github.com/magma/magma/pull/13428 only provided a temporary mitigation of the problem but not a real fix.

grafik

That means, that this issue should be reopened until a proper fix is provided.