search

magma / magma

Platform for building access networks and modular network services
https://www.magmacore.org/
Other
1.67k stars 598 forks source link

[CI] Workaround to support Reviewdog pr-gh-review comments #6266

Closed electronjoe closed 2 years ago

electronjoe commented 3 years ago

Github Actions operating on Forked repo merge PR operate with Tokens that lack write permission to the review API.

We use Reviewdog for many of our GH Action linting activities. It's a very capable library with many features that prove helpful for reducing volume, and it can support automated PR review comments which would be very desirable.

Due to the Token permissions issue, Reviewdog falls back to pr-gh-check behavior for Magma (by emitting specially shaped log messages in the GH Action) to support fallback annotations. But actual review comments would be more visible and enable reviewers to comment on or remove findings from the review process.

There seem to be a few possible strategies to re-enable write permission to the Review API by Forked repo Merge PRs, we should explore them and see if ReviewDog is open to making something more standardized as a work-around.

stale[bot] commented 2 years ago

This pull request has been automatically marked as stale because it has not had any recent activity by the author or maintainer in the past 45 days. It will be closed if no further activity occurs in the next 7 days. Thank you for your contributions.

stale[bot] commented 2 years ago

This pull request has exceeded its lifecylce and will be closed. Should you wish to continue working on this, please reopen it or start a new pull request. Thank you again for your contributions.