search

magma1447 / greasemonkey-geocaching-projectgc

Adds links and data to Geocaching.com to make it collaborate with Project-GC.com
MIT License
18 stars 14 forks source link

Giant duplicate messages button when premium renewal button is present #100

Closed ajs256 closed 3 years ago

ajs256 commented 3 years ago

When your GC.com premium membership is within a month of expiring, a "Renew" button is added to the toolbar. This breaks the script's injected menu.

image

The button has classes of cta-upgrade desktop-upgrade-cta.

magma1447 commented 3 years ago

It took me a while to realize that it's the premium membership at Geocaching.com that's expiring. You most likely meant that, I just read it wrong initially. This is a bit hard to fix due to the simple fact that it's hard to reproduce when your membership isn't close to expire.

If you have the knowledge, you are more than welcome to submit push requests.

capoaira commented 3 years ago

I think the bug is a result of my last change to support the new header. I should get the Renew Button within the next few days. (How many days before expiry did you see the button @ajs256?)

ajs256 commented 3 years ago

How many days before expiry did you see the button?

A month.

capoaira commented 3 years ago

Hmm, I do not see the "Renew" button, but it is only a half moth to the Renewal Date...

ajs256 commented 3 years ago

Well that's weird, I no longer see the button either! They must have pushed an update recently.

capoaira commented 3 years ago

I can reproduce the bug with a non-premium account. The fix comes in PR #101