search

magma1447 / greasemonkey-geocaching-projectgc

Adds links and data to Geocaching.com to make it collaborate with Project-GC.com
MIT License
18 stars 14 forks source link

Add latest logs #109

Closed magma1447 closed 2 years ago

magma1447 commented 2 years ago

The Add latest logs feature has stopped working.

rteitelman commented 2 years ago

Well I looked at the code and don't have any idea why it's not working. Line 1101: // Show latest logs // Enhanced Nov 2016 to show icons for up to 5 of the latest logs if (IsSettingEnabled('addLatestLogs') && latestLogs.length <= 5) { var images = latestLogs.join('');

jewettg commented 2 years ago

@magma1447 - I worked with @rteitelman and we have found a fix! If I could be added as a contributor, I will create a branch, and submit pull request with my change. It is minor for this one; but there are other fixes that I would like to help with! :)

The code on line 1082: $(jNode).find -- the search string for the the div class fails. They have added another layer with a span, which blows it up. 1085 forces the function to return with a false since the find fails, returning a length of 0.

rteitelman commented 2 years ago

magma1447..... my buddy jewettg found the problem with the script I reported April 25. I tested and it works. Can you make him a Contributor to Github? PS - His Geocaching name is GeoJewett. He's also looking at something else with the script.

magma1447 commented 2 years ago

@magma1447 - I worked with @rteitelman and we have found a fix! If I could be added as a contributor, I will create a branch, and submit pull request with my change. It is minor for this one; but there are other fixes that I would like to help with! :)

The easiest is to fork the repository here on GitHub. Submit a fix there, and then make a pull request. When the pull request is accepted (manual process by me) the one making the pull will automatically be added as a contributor. I am not an expert, but in case you don't find your way around GitHub I will try to help.

jewettg commented 2 years ago

@magma1447 - Pull request has been made. Moving on to other changes @rteitelman needs fixed.