search

magma1447 / greasemonkey-geocaching-projectgc

Adds links and data to Geocaching.com to make it collaborate with Project-GC.com
MIT License
18 stars 14 forks source link

2022-08-23 Notes for fork merge #110

Closed jewettg closed 1 year ago

jewettg commented 1 year ago

In addition to my change on lines 1081-1083, I noticed quite a few changes that I personally did not make.

The pull request contains a lot of changes that seem to be cosmetic in formatting (spacing, etc..). Maybe my editor made these changes, or some other aspect of GreaseMonkey editor made these updates.

I reviewed all the changes and can not find any functional changes other than mine that I a committing at this time.

jewettg commented 1 year ago

This should close Issue #109

magma1447 commented 1 year ago

I don't really like the commit to be honest. And with even more honesty, it's with deep regret I am saying it, because I also really appreciate that someone cares and helps out with this script. It really needs some more attention than it has gotten. Here are my thoughts.

  1. I don't care too much if the formatting of the whole code changes. It has been submitted by different people and uses some mixed standards. Surfoo cleaned it up once, but it's back to being quite mixed.
  2. I would prefer that the actual change in this commit was a separate commit. So my suggestion is to make one commit with no real changes that just adjusts the formatting so that it suits you (your editor), and one with the actual change. The formatting commit message could be "code style" or whatever.
  3. There is a huge block of code handling geotags in jpegs. That's a copy/paste from someone else's code. I would really prefer if that one was in it's original form. But if not possible, at least make that a separate commit as well, so in that case two "code style" commits.

If you copy/paste code from Greasemonkey/Tampermonkey you will ruin the formatting of the code. Those editors has their own magic. I really avoid them, or when I do, I just play around there, then I copy paste only the relevant lines into my real editor to make sure the patch is clean.

Do you think you can remake it like above? I hope you understand that I am not trying to be a pain here.

jewettg commented 1 year ago

I completely understand. I did not make the changes, I was actually surprised when they showed up it my changes list during the commit stage. Bizarre. I will close this, and resubmit.