search

magma1447 / greasemonkey-geocaching-projectgc

Adds links and data to Geocaching.com to make it collaborate with Project-GC.com
MIT License
18 stars 14 forks source link

Logs Summary line typo: Extra single quote #112

Closed rteitelman closed 1 year ago

rteitelman commented 1 year ago

The line right before the logs begin has a logs summary that looks like this: View all logs (9) | Yours (1) | Friends' | View Gallery (1) NOTE: Above line is for my view of GC9VGC

that value of Yours is wrong, I have 2 logs not 1. Friends' has no value. It should be 1. Godot is my friend with 1 log. I think that single ' is a typo after the word Friends

jewettg commented 1 year ago

@rteitelman - I can not find a Geocache with the GC code of "GC9VGC". So that is making it hard to debug.

I found where the single quote is showing up in the Friends link, and you are right, it is a code typo, as I can not think of a reason why that is there. However, I can remove the single quote but it will not show the number afterwards. I found where the log summary line is, and where it generates the text that it inserts, but I can not figure out where the numbers are coming from. There is no obvious code that explains how that is being calculated or inserted.

I tried a couple of other cache pages, and "Yours" shows up as "1", not sure if that is correct or not, but Friends never calculates or displays a number.

I was going to roll this into 2.3.15; but I can not verify the issue.

rteitelman commented 1 year ago

Try, #82 Bad to the Bone! Mystery Cache - GC8C0RY

It displays "Friends'" with no number, BUT if you click on that link, you'll see that gc.com knows the number (for me) is 6. So get the number from there? Possible? Does that help?

jewettg commented 1 year ago

@rteitelman - OK, I found the code that populates the number of Geocaches in "Yours (#)". It is a ID tag that is updated with the preference:

There is no such setting for calculating the number of friends logs; at least that I can find. Not that this can not be added, it just is not there yet. Please create a new feature request (issue) for this functionality.

As for incorrect count, please find me a Geocache page that causes the script to display the incorrect number of "Yours(#)" logs.

This issue was for TWO things:

rteitelman commented 1 year ago

ok, new issue opened for this......titled: Incorrect "Yours" count on the log summary line showing count of: All Logs, Yours, Friends, Gallery

On Wed, Aug 24, 2022 at 1:27 PM Greg Jewett @.***> wrote:

@rteitelman https://github.com/rteitelman - OK, I found the code that populates the number of Geocaches in "Yours (#)". It is a ID tag that is updated with the preference:

  • IsSettingEnabled('addMyNumberOfLogs')
  • IsSettingEnabled('logbookLinks')

There is no such setting for calculating the number of friends logs; at least that I can find. Not that this can not be added, it just is not there yet. Please create a new feature request (issue) for this functionality.

As for incorrect count, please find me a Geocache page that causes the script to display the incorrect number of "Yours(#)" logs.

This issue was for TWO things:

  • Remove the typo of a single-quote that was showing up on "Friends'" log link. (FIXED)
  • A reported incorrect number of logs for "Yours (#)". (Need to verify bug)

— Reply to this email directly, view it on GitHub https://github.com/magma1447/greasemonkey-geocaching-projectgc/issues/112#issuecomment-1226082609, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQF3ITOXXQNHD43MQNMHO3TV2ZSRTANCNFSM57MXSINQ . You are receiving this because you were mentioned.Message ID: @.*** com>

jewettg commented 1 year ago

115 now replaces the "A reported incorrect number of logs for "Yours (#)". (Need to verify bug)" part of this issue. This issue is now just " Logs Summary line typo: Extra single quote #112"; and will be fixed and closed.