search

magma1447 / greasemonkey-geocaching-projectgc

Adds links and data to Geocaching.com to make it collaborate with Project-GC.com
MIT License
18 stars 14 forks source link

Update greasemonkey-geocaching-projectgc.user.js #134

Closed rteitelman closed 1 year ago

rteitelman commented 1 year ago

Besides the two typos I made apparently in 3.2.16 which caused the script to not load (and was caught and fixed in 3.2.17), I left out one line when revising the file. Fixed in this new file lines 342-343

            // Issue 133; fixed 2022-09-04 (Units of elevation obtained from Project-GC)
            imperialFlag = result.data.imperialUnits;
jewettg commented 1 year ago

@cghove Thank you for pushing 2.3.16 fixes. I reviewed the code, but did not import it into my GreaseMonkey .. so I missed the syntax errors. Ugh. Well that won't happen again, at least I will try. Thanks again!

@rteitelman - YIKES! Dang it! Just what I feared, when there were so many branches (mine, yours, etc..) I cleaned up my branches .. and will pull down yours and test first. I will merge the pull once I have tested.

rteitelman commented 1 year ago

OK, it should be good and it should fix the issue.

jewettg commented 1 year ago

I can not get this pull request to merge .. due to conflict. I am going to close this pull, and recreate it, using a new branch. I will issue the pull and review.