magmaOffenburg / RoboViz

Monitor and visualization tool for the RoboCup 3D Soccer Simulation League
Apache License 2.0
50 stars 17 forks source link

Catching bad nan values being parsed from server. #103

Closed pmacalpine closed 6 years ago

pmacalpine commented 6 years ago

Catching bad nan value sent by server. This should fix #99 .

Gama11 commented 6 years ago

Oh, I missed this and implemented pretty much the same fix here: https://github.com/magmaOffenburg/RoboViz/commit/9c8740735718239d5ce357ff28c317a1ba1a4e05

I'm not sure if it's actually a good idea to use it though, as this makes it look like everything is fine (when in fact one player is missing).

pmacalpine commented 6 years ago

Yeah, and your fix might be better in that it still prints the stack trace of the error. Not sure if setting a[i] to 0 like I was doing or not changing it is best.