magmaOffenburg / RoboViz

Monitor and visualization tool for the RoboCup 3D Soccer Simulation League
Apache License 2.0
52 stars 17 forks source link

Roboviz GUI rewrite Kotlin #117

Closed Seil0 closed 2 years ago

Seil0 commented 4 years ago

This PR is a rewrite of the main java gui part of RoboViz to kotlin. The Goal is to better separate Java swing code from the Renderer. I try to use as much standard swing components as possible to improve maintainability.

Features:

Fixed Regressions/Other

TODO:

Fixed Issues:

Seil0 commented 3 years ago

Since all features are implemented and nearly all minor issues have been fixed please test the pre-release version from below.

pre-release-1: RoboViz.tar.gz

Seil0 commented 3 years ago

If no major issues or regressions will be found this will be the last pre-release before merging this pr.

pre-release-2: RoboViz.tar.gz

klausdorer commented 3 years ago

I would prefer to have the server connections in the connection view sorted as in the config file for more convenience. May be you can use a LinkedHashmap to manage the connections that keeps the order of insertion?

hannesbraun commented 3 years ago

I just had a weird problem where selecting agents (or the ball) by clicking them was not possible. @klausdorer also had this issue. While searching for the problem this the issue disappeared (at least for me). I'm not really sure if we both coincidentally misclicked or if this issue is something more severe. Maybe @Seil0 can have a look at this/test this again.

klausdorer commented 3 years ago

Player/Ball selection worked (now on Windows) until I once switched to log mode and back. Then it did no longer work. When trying if a restart helps, I can no longer connect to the servers in Offenburg. The application hangs completely and can not even be closed after choosing menue Connection->. No error message in the console window.

Seil0 commented 3 years ago

I just tried to reproduce the issues myself. I can confirm the player selection issue after switching between log mode and live mode. But i couldn't reproduce the other issues using a locally running server.

Seil0 commented 3 years ago

The selection issue should be fixed now.

klausdorer commented 3 years ago

On my Linux I do not have the issue reported that application hangs on connections. But on Windows I did the following:

hannesbraun commented 3 years ago

Another issue I noticed with this new version is a camera offset when playing log files (with ball tracking enabled). After some time, a switch occurs and it looks like the camera is focussing the ball with an offset. So far, I haven't seen a similar issue with the previous version of RoboViz. However I'm not completely sure, since this issue does not occur on every replay.

hannesbraun commented 3 years ago

pre-release-3: RoboViz.tar.gz

klausdorer commented 3 years ago

The problem still persists on my computer.

  1. build RoboViz
  2. start RoboViz and connect to a server (store in config file) -> works
  3. stop RoboViz
  4. start RoboViz again
  5. connect to the stored connection -> RoboViz hangs, no menu click, no stopping RoboViz
hannesbraun commented 2 years ago

The problem still persists on my computer.

  1. build RoboViz
  2. start RoboViz and connect to a server (store in config file) -> works
  3. stop RoboViz
  4. start RoboViz again
  5. connect to the stored connection -> RoboViz hangs, no menu click, no stopping RoboViz

Fixed with a1be0cce666af03534eefbf470586c027bd51cfa