magmaOffenburg / RoboViz

Monitor and visualization tool for the RoboCup 3D Soccer Simulation League
Apache License 2.0
51 stars 17 forks source link

Fixing start script so that it will properly process the tilda charac… #81

Closed pmacalpine closed 8 years ago

pmacalpine commented 8 years ago

…ter in command line arguments. Using the eval command for this fix, which can be dangerous from a security standpoint, however user input is contained as an argument to the dirname command so I doubt anything too evil could be executed. Also I'm not exactly worried about security issues with roboviz. Closes #80.

Gama11 commented 8 years ago

Hm... looks like this is a consequence of #77. I remember specifically adding support for ~ on the Java side here: a8f8c6833047cc051d4585889bcb2eeacd83bb04

In retrospect, I'm not a huge fan of how complex the roboviz.sh became in #77 (although it is of course a nice feature).

Anyway, thanks for the fix!