search

magmax / python-readchar

Python library to read characters and key strokes
MIT License
143 stars 43 forks source link

Add some linters to the CI #108

Closed pomponchik closed 5 months ago

pomponchik commented 5 months ago

Hello!

I see that you're using flake8, but i can't see it in the workflows. What about to add running some linters as a new workflow? And I suggest to use Ruff instead of flake8.

Cube707 commented 5 months ago

What are the relevant upsides of ruff? flake8 has not cased any issues up to this point, so why switch?

pomponchik commented 5 months ago

There is only one reason to use ruff - speed. You can save some time if you use it.

Cube707 commented 5 months ago

with an empty cache ruff was only 50ms faster than flask8 (on my machine), the project is simply to small to create really notable differences.

Doesn't justify moving away from tools that come from the official python team.

pomponchik commented 5 months ago

But what about adding any linters to the CI workflow?

Cube707 commented 5 months ago

CI worklflow runs flake8 (any all other pre-commit steps).

So I don't get what you are suggesting