search

magmax / python-readchar

Python library to read characters and key strokes
MIT License
143 stars 43 forks source link

Remove `setuptools` dependency #116

Closed aeisenbarth closed 3 months ago

aeisenbarth commented 3 months ago

I could be mistaken, but to me it seems python-readchar should not specify setuptools as install requirement. Typically it is provided by the environment, or specified as build requirement. It is never imported and used in order to run readchar.

As a consequence, a specific version of setuptools leaks into my lock files and I have to specifically exclude it.

See also https://github.com/magmax/python-readchar/issues/111. In pyproject.toml, there would be:

[build-system]
requires = ["setuptools", "wheel"]

[project]
dependencies = [
]
aeisenbarth commented 3 months ago

Similar case https://github.com/Gandi/gandi.cli/issues/249 See also: https://stackoverflow.com/questions/65326080/python-setup-config-install-requires-good-practices

aeisenbarth commented 3 months ago

Thanks!