search

magmax / python-readchar

Python library to read characters and key strokes
MIT License
143 stars 43 forks source link

Run tests on BSDs, too. #86

Open trombonehero opened 2 years ago

trombonehero commented 2 years ago

Now that FreeBSD support has been added to readchar/key.py, these tests run just fine.

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 98.235% when pulling 4636e0cea4cf5ef3d0feaad9f9eea2629b4959a5 on trombonehero:bsd-tests into 01b4b0ae01b1f4efab83cd7f62464cb5187760a2 on magmax:master.

Cube707 commented 2 years ago

Thank you for this PR. I also thought about this, but if this gets incorporated we would also have to extend the CI test-workflow. And than comes the question, why only BSD? Why not MacOS also? And others?

This gets more complicated than I am willing to handle and also would require somebody to handle isses that come up from this. This is also why the testfolder is still named Linux and not Posix like the sourcefiles. Tests are only provided / supported for Linux and Windows and more is not actively maintained.

Everyone is of course free to remove the guard-staments and run the tests on this own risks.