search

magmax / python-readchar

Python library to read characters and key strokes
MIT License
143 stars 43 forks source link

Fix ENTER on macos #89

Closed fleytman closed 2 years ago

fleytman commented 2 years ago

After merge https://github.com/magmax/python-readchar/pull/79 in macos was broken enter. It's fix.

And i include https://github.com/magmax/python-readchar/pull/70

coveralls commented 2 years ago

Coverage Status

Coverage decreased (-3.2%) to 92.179% when pulling 0655497a98e9056871005ac55c56a23f3677aa18 on fleytman:fix_macos_keys into 5421325536eb81e75bcf29f75446b0d5ea67cf29 on magmax:master.

Cube707 commented 2 years ago

I am not jet sure if I prefere the "proper" way of having a seperate file for mac, or if I am fine with a dirty override in the __init__ file (nobody needs a file with only one line...). I will have to sleep on that. leav it as is for now

Cube707 commented 2 years ago

also please rebase to current master, as some stuff changed in 77c1ac5

Cube707 commented 2 years ago

and do you have access to a mac? can you provide screenshot of the tests/manual-test.py file not working currently with ENTER but after the fix? That would be great for documentation.

fleytman commented 2 years ago

Now my Mac uses \n, but I remember exactly what didn't work and was saved only by changing to \r. I think now you can close the MP, and if I reproduce there will already be additional data in what situation such a problem appears.

Cube707 commented 2 years ago

OK, thats weird 🤦🏼‍♂️ Definitely open a new issue if you can reproduce it 👍🏼

Cube707 commented 2 years ago

you can still open a PR for your refactoring of the if statements. Thats a nice idea.