Closed fleytman closed 2 years ago
I am not jet sure if I prefere the "proper" way of having a seperate file for mac, or if I am fine with a dirty override in the __init__
file (nobody needs a file with only one line...). I will have to sleep on that. leav it as is for now
also please rebase to current master, as some stuff changed in 77c1ac5
and do you have access to a mac? can you provide screenshot of the tests/manual-test.py
file not working currently with ENTER but after the fix? That would be great for documentation.
Now my Mac uses \n, but I remember exactly what didn't work and was saved only by changing to \r. I think now you can close the MP, and if I reproduce there will already be additional data in what situation such a problem appears.
OK, thats weird 🤦🏼♂️ Definitely open a new issue if you can reproduce it 👍🏼
you can still open a PR for your refactoring of the if
statements. Thats a nice idea.
After merge https://github.com/magmax/python-readchar/pull/79 in macos was broken enter. It's fix.
And i include https://github.com/magmax/python-readchar/pull/70