magmodules / magento2-channable

Channable Connect for Magento® 2
https://marketplace.magento.com/magmodules-magento2-channable.html
BSD 2-Clause "Simplified" License
28 stars 40 forks source link

Parent Product Stock Issue if Stock is Unmanaged #192

Closed kaplansin closed 1 year ago

kaplansin commented 1 year ago

Channable feed generation checks cataloginventory_stock_item.is_in_stock for stock status of parent product. But for Unmanaged stock Items it should also check manage_stock and use_config_manage_stock flags together.

For Unmanaged stock Items, magento is not updating is_in_stock value in cataloginventory_stock_item table. This can cause missing products in the feed.

\Magmodules\Channable\Helper\Product::validateProduct

$filters = $config['filters'];
        if (!empty($parent)) {
            if (!empty($filters['stock'])) {
                if (!$parent->getIsInStock()) {
                    return false;
                }
            }
        }
kaplansin commented 1 year ago

https://github.com/magmodules/magento2-channable/pull/193

Frank-Magmodules commented 1 year ago

Thank you @kaplansin for your pull request on this. 
We are thrilled to announce that it has now been merged into our latest release!