magmodules / magento2-channable

Channable Connect for Magento® 2
https://marketplace.magento.com/magmodules-magento2-channable.html
BSD 2-Clause "Simplified" License
28 stars 40 forks source link

Change some methods to public to be accessible for plugins #196

Closed sanderjongsma closed 1 year ago

sanderjongsma commented 1 year ago

There are a lot of private functions and in my opinion some of them should be public to make them accessible for plugins in Magento. In this PR case I changed just two methods because I need them to be accessible to add some changes on client level and I think they don't need to be private.

sanderjongsma commented 1 year ago

Other possibilities are:

Just letting you know how private functions can limit your options.