magmodules / magento2-sooqr

Sooqr Connect for Magento® 2
https://www.magmodules.eu/sooqr-connect.html
Other
2 stars 3 forks source link

Make credential fields sensitive and encrypt API Key #33

Closed gsomoza closed 4 years ago

gsomoza commented 4 years ago

This PR marks a couple of fields as "sensitive" to avoid them being dumped into app/etc/config.php (a file that might be versioned).

Backwards Compatibility

No BC breaks under SemVer. Additionally:

With the above in mind, this could be released with just a revision bump (e.g. 1.1.5) along with simple upgrade instructions, e.g. After upgrading, go to the Sooqr settings page and click on 'Save' without making any other changes.